Bump supported and testes Python versions

scikit-learn-contrib / scikit-matter

A collection of scikit-learn compatible utilities that implement methods born out of the materials science and chemistry communities

https://scikit-matter.readthedocs.io/en/v0.2.0/

BSD 3-Clause "New" or "Revised" License

76 stars 20 forks source link

Bump supported and testes Python versions #228

Closed PicoCentauri closed 5 months ago

PicoCentauri commented 5 months ago

Following sklearn the new supported Python versions are ranging from 3.9 - 3.12. I also simplified the syntax in test matrix a bit.

📚 Documentation preview 📚: https://scikit-matter--228.org.readthedocs.build/en/228/

agoscinski commented 5 months ago

Looks good. Can be merged like this!

Maybe one can fix in another PR (next time we touch tox.ini) the version for the lint, build and docs environment to avoid mismatching github workflow and local versions that produce for example different linting errors. As far as I understand the tox docs it is just

basepython = py312

If you agree the suggestion I can make an issue for this

PicoCentauri commented 5 months ago

Looks good. Can be merged like this!

Maybe one can fix in another PR (next time we touch tox.ini) the version for the lint, build and docs environment to avoid mismatching github workflow and local versions that produce for example different linting errors. As far as I understand the tox docs it is just
basepython = py312
If you agree the suggestion I can make an issue for this

Could be an option. But if developers (including me 🤣) want to build the docs with an older interpreter they can't anymore if we change this. Older versions compared to 3.12 should in principle work.