search

scikit-learn-contrib / skope-rules

machine learning with logical rules in Python
http://skope-rules.readthedocs.io
Other
615 stars 95 forks source link

why is numpy scipy required during installation in setup.py #19

Open AlJohri opened 5 years ago

AlJohri commented 5 years ago

can we remove the following from setup.py? (happy to submit a PR)

try:
    import numpy
except ImportError:
    print('numpy is required during installation')
    sys.exit(1)

try:
    import scipy
except ImportError:
    print('scipy is required during installation')
    sys.exit(1)

pipenv uses python setup.py egg_info to parse the dependency tree and this command fails on initial run when numpy and scipy are not yet installed. fortunately, it does a second pass over failed dependencies and then is able to install skope-rules

why is specifying numpy and scipy as a dependency not sufficient? is there a reason it is "required during installation"?

ngoix commented 5 years ago

I can't remember why it is here, I guess we can remove these lines indeed. @RomainBrault maybe