[MRG] Fix check estimator

scikit-learn-contrib / skope-rules

machine learning with logical rules in Python

http://skope-rules.readthedocs.io

Other

615 stars 95 forks source link

Closed ngoix closed 5 years ago

ngoix commented 5 years ago

tests were failing with new check_estimator

timstaley commented 5 years ago

LGTM :+1: For reference to anyone reading, the check_estimator changes satisfy the coding convention described here: https://scikit-learn.org/stable/developers/contributing.html#instantiation

ecederstrand commented 5 years ago

Ping?