search

scikit-learn-contrib / skope-rules

machine learning with logical rules in Python
http://skope-rules.readthedocs.io
Other
599 stars 96 forks source link

Any variable name can be used in "feature_names" #4

Closed floriangardin closed 6 years ago

floriangardin commented 6 years ago

Now any variable name can be used in the "feature_names" list parameter of Skope Rules. I decoupled the feature names from the internal queries logic.

AlJohri commented 5 years ago

I still ran into a bug with this and had to do something like this to get around it:

feature_names=["w_" + x.replace(' ', '_') for x in featurizer.get_feature_names()])

I'll have to debug exactly what happened but I believe some of my features started with numerical characters and therefore it triggered an error with numexpr