Open fayeab opened 3 years ago
Thanks @fayeab for the good work It is gonna be hard to get reviews on this as a whole though, I would split this PR into at least 3 new ones:
sample_weight
renaming / data getters updatefiltering_criteria
parameterdeduplication_criterion
and custom_func
paramsThese PRs do not need to be independent and are probably to be based on each others 1. <- 2. <- 3.
- shouldn't take much time to split the code and it will make the review process a lot smoother
closes #42
Hello,
I've added two features (filtering and deduplication criteria) for skope rules.
This work is an improvement of #42 We have 3 new parameters for SkopeRule class :
"filtering_criteria" in place of recall_min et precision_min
"deduplication_criterion" in place of the default F1 score deduplication criterion which was used in deduplicate function