search

scikit-learn-contrib / skope-rules

machine learning with logical rules in Python
http://skope-rules.readthedocs.io
Other
599 stars 96 forks source link

Fix/update tests #54

Closed AndrewTanQB closed 3 years ago

AndrewTanQB commented 3 years ago

Description

This PR contains some fixes to get tests working and build passing, primarily around updating tests and imports to handle deprecation of various sklearn testing functions and other imports.

Instead of pinning a new sklearn version, have tried to maintain compatibility with a bunch of try-except blocks, but would be happy to hear thoughts on this approach. May also be worthwhile to add different sklearn versions in the travis CI build.

AndrewTanQB commented 3 years ago

closing PR in lieu of #55 with cleaner diff