search

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
48 stars 34 forks source link

[MRG] Added RTD link in README #10

Closed NicolasHug closed 5 years ago

NicolasHug commented 5 years ago

I've also added @rth @jnothman @ogrisel @GaelVaroquaux as admins of the RTD repo (couldn't find you @amueller?).

This should be enough for RTD to be triggered everytime a new commit is pushed to master, else one of you guys will have to setup the hook manually.

amueller commented 5 years ago

I'm @t3kcit I think.

amueller commented 5 years ago

Can you make the empty sections show up? They don't seem to show on rtd :-/

rth commented 5 years ago

I guess it would have been nice to have enhancement-proposals.scikit-learn.org instead of the current scikit-learn-enhancement-proposals.readthedocs.io with the custom domain support on RTD, but it's not too critical.

amueller commented 5 years ago

@ogrisel can probably do that for us? I also think that it would be nicer. I don't think there is many links to that site yet, so I wouldn't worry about changing it.

NicolasHug commented 5 years ago

@amueller I added you.

I don't know how to show the empty toctrees, there doesn't seem to be an option for that :/

amueller commented 5 years ago

And if you make it headers instead of toctree titles?

NicolasHug commented 5 years ago

I'm not sure what you mean?

I've tried different things and I think the easiest way is just to create empty files for the titles to show up. We can remove them as soon as we add sleps under those sections.

amueller commented 5 years ago

I think it's fine to merge as-is, we can change the url once @ogrisel can change the DNS ;)

amueller commented 5 years ago

that wasn't rendered on rtd for some reason, right?

NicolasHug commented 5 years ago

Yeah I just opened #11 which should solve this

amueller commented 5 years ago

Sorry, I mean the change in the TOC, the empty sections don't show up on rtd

NicolasHug commented 5 years ago

Oh right! Should be fine now, I manually ran the RTD build. One of you guys admins will have to setup the hook if you want this to be automatic.

(#11 is still worth merging maybe)

amueller commented 5 years ago

link for setting up the hook? (yes I'm that lazy/busy)

NicolasHug commented 5 years ago

lol no worries that should be it