scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
48 stars 34 forks source link

SLEP011 Do not make mandatory TC vote during SLEP vote #28

Closed glemaitre closed 4 years ago

adrinjalali commented 4 years ago

For instance, with the resampler SLEP, there needs to be two SLEPs proposing the two solutions, and if one of the is rejected, we don't necessarily want the TC to have to be involved, the slep author can go and modify or have a new one or something. Discussing what will happen in the case of the sleps we already have yesterday, we realized this is an issue which needs to be fixed.

GaelVaroquaux commented 4 years ago

I'm overall fine with the principle of this suggestion. It is a good one!

amueller commented 4 years ago

Not sure if this is our most urgent issue but I'm also ok with it

adrinjalali commented 4 years ago

@glemaitre could you also add this to the under review maybe? we can then merge and call the vote.

amueller commented 4 years ago

The current governance document doesn't require a vote if there is consensus. We have voted on previous SLEPs but there's not really any need to vote for this one, I feel.

adrinjalali commented 4 years ago

The current governance document doesn't require a vote if there is consensus. We have voted on previous SLEPs but there's not really any need to vote for this one, I feel.

That's an interesting point, which makes it possible to make important decisions w/o announcing on the mailing list beforehand. Might be a bug, not a feature :P

amueller commented 4 years ago

You think it is? Well then we should... probably fix that first lol? Add a sentence "before any SLEP is accepted it should be announced on the mailing list"?

amueller commented 4 years ago

Actually, rereading, I think the governance doc is not clear on whether a vote is required :( I thought the intent was to require a vote only if there is disagreement.

GaelVaroquaux commented 4 years ago

That's an interesting point, which makes it possible to make important decisions w/o announcing on the mailing list beforehand. Might be a bug, not a feature :P

Hum, yes.

amueller commented 4 years ago

@GaelVaroquaux did you understand the governance document as always requiring a vote for a SLEP?

rth commented 4 years ago

As a side comment, making votes for SLEPs on the mailing list, especially when there is unanimous agreement and all discussion happened in the PR is probably not very relevant for most subscribed users. For most I imagine it's just noise, which will not help in keeping users subscribed/interested.

I get that we need some public and temper proof way to record votes, but I wonder if the user mailing list is the best place for it.

GaelVaroquaux commented 4 years ago

@GaelVaroquaux did you understand the governance document as always requiring a vote for a SLEP?

No I did not, but the point that you raise about SLEPs slipping below the radar for lack of communication is a good one.

adrinjalali commented 4 years ago

This is an alternative path to reduce noise on the mailing list:

glemaitre commented 4 years ago

I made the changes. I think the proposal of @adrinjalali is what I would expect. We should probably fix these issues as well. What is the path then?

adrinjalali commented 4 years ago

I don't think we need to change anything since the governance model doesn't really specify how it should be done. I'd say we merge, create the next PR to move it as accepted, and call the vote on the mailing list.

amueller commented 4 years ago

So should we merge this? Or 000?

GaelVaroquaux commented 4 years ago

With regards to merging this SLEP, I fear that, in it's current state it would add an extra layer of stuff to read. In other terms, I think that we need to consolidate the information somewhere, elsewhere people will have to dig for this information through many layers. Where is that somewhere, I am not certain. Maybe SLEP 000 is a good way to doing that.

glemaitre commented 4 years ago

So let's focus on SLEP000 and come back once we have something solid.

GaelVaroquaux commented 4 years ago

I think that this is a pragmatic view! :)