search

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
48 stars 34 forks source link

SLEP007: Meta-estimators section expansion #31

Closed adrinjalali closed 4 years ago

adrinjalali commented 4 years ago

@amueller has the following concern on the meta-estimators section of the SLEP:

Shouldn't we list all meta-estimators that are transformers? What about FeatureUnion and RFECV? I guess maybe we're talking about meta-estimators that are not feature selectors, because those are easy.

I'm personally not sure. I kinda prefer to have a guideline which can be used to the meta estimators, rather than listing them in the SLEP.

amueller commented 4 years ago

I'm ok with the current phrasing of the SLEP in that regard.