Questions and comments about SLEP006 -- Sample props

[NicolasHug]

1.

we can consider the use of keys that are not limited to strings or valid identifiers (and hence are not limited to using _ as a delimiter).

I don't understand how we are currently limited to using _ as a delimiter. Should this be __? But even then I still don't follow.

2.

TODO: proceed from here. Note that this change implies the need to add a parameter to unwrap_X, since we will now append an additional column to X.

I don't understand why we don't need to add an additional column to X in this case.

3.

while a GridSearchCV wrapping a Pipeline currently takes parameters with keys like {step_name}{prop_name}, this explicit routing, and conflict with GridSearchCV routing destinations, implies keys like estimator__{step_name}{prop_name}.

I'm not sure I completely understand this. A small illustration might help? Also, does "GridSearchCV routing destinations" refers to param_grid instead?

4.

All consumers would be required to check that

This sentence seems unfinished?

5.

Here the meta-estimator provides only what its each of its children requests. The meta-estimator would also need to request, on behalf of its children, any prop that descendant consumers require.

I could be wrong, but this doesn't seem to define the "essence" of solution 4. It seems to me that in solution 3, as well, the meta estimators only provides what the childrens need/request?

• There are still a bunch of TODOs: we should remove them before calling for a vote
• Related: "(likley out of scope) passing sample properties..." The scope of the SLEP should be non-ambiguous so maybe we want to remove this bullet point.
• Not important but the use # %% doesn't render in the html docs.
• It would help to have a brief description of the proposed solution at the top, or an "abstract" section, as per our SLEP template.

[NicolasHug]

Sorry pressed too soon, closing, don't want to open this now