Amend / Converge on Slep 6 on sample props aka now as metadata

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications

https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest

BSD 3-Clause "New" or "Revised" License

47 stars 34 forks source link

Amend / Converge on Slep 6 on sample props aka now as metadata #50

Closed agramfort closed 3 years ago

agramfort commented 3 years ago

See https://hackmd.io/Psfd7aB1Qt6_fwv-EBVXqQ for some content.

@adrinjalali @jnothman

I mostly moved to other.rst the solutions we decided not to consider and I started to amend the proposal.rst with what we converged on during our discussion.

Feel free to push to my PR so it looks more like what https://github.com/scikit-learn/scikit-learn/pull/16079 implements.

Let's keep the ball rolling...

jnothman commented 3 years ago

Thanks @agramfort for cleaning this up.

jnothman commented 3 years ago

This is marked WIP, but I'd be happy to approve.

adrinjalali commented 3 years ago

We're having another session next Tuesday to finish our pair-editing and then it should be ready :)

agramfort commented 3 years ago

@jnothman we have finished our pass with @adrinjalali

floor is yours !

agramfort commented 3 years ago

@jnothman feel free to push directly here. thx

jnothman commented 3 years ago

I'm fine to merge this as is, btw. And then, I suppose, move to a vote??

adrinjalali commented 3 years ago

Sounds good to me.

agramfort commented 3 years ago

thanks for finishing this guys !