scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

SLEP needed: warm starting with Pipelines, and safer warm starting #51

Open jnothman opened 3 years ago

jnothman commented 3 years ago

It should be possible for an estimator to check or propose that a particular parameter change would be appropriate to do with warm start. It should also be possible to for the estimator's fit to be aware of what parameters have changed for its warm start.

See https://github.com/scikit-learn/scikit-learn/pull/8230#issuecomment-468907013

NicolasHug commented 3 years ago

What followed from the aforementioned comment is https://github.com/scikit-learn/scikit-learn/pull/15105 (closed, but can be re-opened).

Also related: these notes on how warm-starting within a grid search is fundamentally different from warm-starting within SH https://github.com/scikit-learn/scikit-learn/issues/15125

jnothman commented 3 years ago

Thanks for the reminders! These got lost from my agenda when I lost some browser tabs....