search

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

Mark implemented SLEPS #56

Open lorentzenchr opened 3 years ago

lorentzenchr commented 3 years ago

As of today, https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/index.html lists two SLEPs as accepted:

It is, however, not clear from the webpage if those SLEPs are implemented. I propose to link at least the scikit-learn version, maybe also relevant PRs, that implemented them.

glemaitre commented 2 years ago

In Python, there is a "Final" status to acknowledge that the PEP is implemented. We could do something similar by listing them separately and adding the scikit-learn version where the interface is stable.

glemaitre commented 2 years ago

I assume that it should be part of the SLEP000: https://github.com/scikit-learn/enhancement_proposals/pull/30/files

glemaitre commented 2 years ago

Actually, this something this is mentioned here and could be improved: https://github.com/scikit-learn/enhancement_proposals/pull/30/files#r758344193