search

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

[VOTE] Accept SLEP000 #64

Closed adrinjalali closed 2 years ago

adrinjalali commented 2 years ago

This PR is the place for us to vote for SLEP000: https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/slep000/proposal.html

It was discussed in depth in https://github.com/scikit-learn/enhancement_proposals/pull/30, but no unanimous consensus was achieved there.

Therefore here's the vote for us to see if it passes our majority. We require 2/3 of the cast vote (no quorum) to pass the SLEP.

The vote closes on 4th February 2021.

NicolasHug commented 2 years ago

I'm not against merging early, but I'm strongly against a process that will prevent additional feedback and comments from being adequately expressed and addressed https://github.com/scikit-learn/enhancement_proposals/pull/30#issuecomment-982519521.

The proposed workflow in this SLEP has limitations that have been voiced by multiple core devs (https://github.com/scikit-learn/enhancement_proposals/pull/30#issuecomment-982519521, https://github.com/scikit-learn/enhancement_proposals/pull/30#issuecomment-982946316, https://github.com/scikit-learn/enhancement_proposals/pull/30#issuecomment-994672509), but they are not addressed nor acknowledged in this SLEP proposal.

For these reasons I'm -1, sorry.

ogrisel commented 2 years ago

+1 for accepting the SLEP the way it is (merge Draft PR early). I think we can improve the review/discussion without setting it in stone SLEP 000.

One idea could be to maintain an open META discussion issue for each SLEP in Draft state to centralize the discussion with a maintained list of open discussion topics in its description with potential links to sub-issues and sub-PRs related to the draft SLEP for instance.

adrinjalali commented 2 years ago

Counting the votes, it's 10 in favor (votes above plus myself), and one opposed. The vote satisfies 2/3 majority of cast votes. Therefore this motion (accepting SLEP000) is passed per our governance.