scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

SLEP017: clone override #67

Closed jnothman closed 1 year ago

adrinjalali commented 1 year ago

@jnothman wanna merge and call for a vote?

haiatn commented 1 year ago

I am not sure but because of linked issues it may close one or more of the following: https://github.com/scikit-learn/scikit-learn/issues/5563 https://github.com/scikit-learn/scikit-learn/pull/9696 https://github.com/scikit-learn/scikit-learn/issues/16137 https://github.com/scikit-learn/scikit-learn/pull/16185

amueller commented 1 year ago

+1 on merge and vote :)

amueller commented 1 year ago

@jnothman wanna merge and call a vote?

amueller commented 1 year ago

Merging and calling a vote, assuming @jnothman doesn't have time to push this forward right now (@adrinjalali and @glemaitre gave me :+1:)

lorentzenchr commented 1 year ago

I think SLEP017 should be mentioned in index.rst in to be able to find in in the homepage navigation.

amueller commented 1 year ago

@lorentzenchr yeah I noticed that that was missing from this PR. I wasn't sure if adding it in the voting PR would be enough, I can send another PR to add it to the index.rst before the vote ends?

haiatn commented 1 year ago

I am not sure but because of linked issues it may close one or more of the following: scikit-learn/scikit-learn#5563 scikit-learn/scikit-learn#9696 scikit-learn/scikit-learn#16137 scikit-learn/scikit-learn#16185

Can these be closed/completed?

adrinjalali commented 1 year ago

@haiatn thanks for the note. Closed those issues/PRs.