search

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

Add X,y,Y to ignored list #69

Closed adrinjalali closed 1 year ago

adrinjalali commented 2 years ago

X,y,Y are automatically ignored in the routing mechanism when we infer routed parameters.

xref: https://github.com/scikit-learn/scikit-learn/pull/23342#discussion_r891331438

cc @thomasjpfan

adrinjalali commented 1 year ago

I think it's not the SLEP which is changing, they're implementation details. I don't think it'd be healthy for this SLEP to go back to not being accepted.

jjerphan commented 1 year ago

Yep, from my understanding of SLEP000, I not think Provisional means it is not Accepted. But nevermind: this is just a small interjection.

adrinjalali commented 1 year ago

Then I'll merge this with 4 approvals.