search

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

Rename repository to slep for nicer url #7

Closed amueller closed 5 years ago

amueller commented 5 years ago

I would suggest renaming this repo to slep so we can have scikit-learn.github.io/slep instead of scikit-learn.github.io/enhancement_proposal.

GaelVaroquaux commented 5 years ago

I would suggest renaming this repo to slep so we can have scikit-learn.github.io/slep instead of scikit-learn.github.io/enhancement_proposal.

As you wish. I find that "slep" is not a very clear name (though I like it), and I would find "enhancement_proposal" more explicit.

amueller commented 5 years ago

In what context would there be need to clarify? I don't think anyone that remembers either of the urls will be confused. On the org page each repo has a description, so I think it's pretty clear from the description. We could probably have the URL not match the repo name but I'm not sure if it's worth the hassle.

GaelVaroquaux commented 5 years ago

In what context would there be need to clarify?

When it is communicated to someone outside the community of scikit-learn developers. But maybe that's not a worthwhile goal.

NelleV commented 5 years ago

That's actually an interesting point (although I'm not sure it's worthwile either). It just makes me think of a collaborator giving a presentation, and having to explain "PEP" to a wide audience of non programmers.

Anyhow, I also like the name SLEP, and I really don't have a valuable opinion to share :)

amueller commented 5 years ago

When it is communicated to someone outside the community of scikit-learn developers.

I don't know what "it" is in this sentence. The url of the website? The github repo?

Not sure where to have the other discussion on the now-closed PR on whether to build in the main website.

GaelVaroquaux commented 5 years ago

I don't know what "it" is in this sentence. The url of the website? The github repo?

The URL of the SLEP.

Not sure where to have the other discussion on the now-closed PR on whether to build in the main website.

Me neither. But I guess this brings arguments in favor of a separate tracker, to sort out PRs and issues?

amueller commented 5 years ago

The URL of the SLEP.

I think it'll be rare to communicate a SLEP URL to someone outside the project. We will still have a link to enhancement proposals on the main website, right?

But I guess this brings arguments in favor of a separate tracker, to sort out PRs and issues?

Yes. And we kind of had that discussion on the governance doc. I think we should just put some sphinx in here and be done with it for now maybe? But not sure what @jnothman thinks.

GaelVaroquaux commented 5 years ago 
The URL of the SLEP.

I think it'll be rare to communicate a SLEP URL to someone outside the project. We will still have a link to enhancement proposals on the main website, right?

Well yes, but think about 'pep8': it's really jargon. That said I don't have a strong opinion. I just like to avoid jargon and acronyms in general.

Yes. And we kind of had that discussion on the governance doc. I think we should just put some sphinx in here and be done with it for now maybe?

+1

jnothman commented 5 years ago

I'm not in the mood for thinking about these things, sorry. Happy with whatever goes.

agramfort commented 5 years ago

I think enhancement_proposals is more explicit.

amueller commented 5 years ago

alright then

chkoar commented 4 years ago

Late to the game but I would rename the repo as the rtd site. scikit-learn-enhancement-proposals or at least enhancement-proposals.