search

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
48 stars 34 forks source link

VOTE SLEP 17 #79

Closed amueller closed 1 year ago

amueller commented 2 years ago

This PR is for us to discuss and collect votes for SLEP017 - Clone Override Protocol with __sklearn_clone__. The current implementation is available at https://github.com/scikit-learn/scikit-learn/pull/24568. Note that this vote is for the API and the implementation can be adjusted.

According to our governance model, the vote will be open for a month (till Dec 1st), and the motion is accepted if 2/3 of the cast votes are in favor.

@scikit-learn/core-devs

glemaitre commented 2 years ago

A question before voting.

The SLEP states that we will use the estimator checks to ensure that the fundamental properties of clone are preserved. Currently, we don't have such a check. I am wondering if the SLEP should define "the contract" that we will be checking in check_estimator?

adrinjalali commented 2 years ago

am wondering if the SLEP should define "the contract" that we will be checking in check_estimator?

I rather have that discussion concretely in the PR where we write those tests instead. Having that discussion here would add another 6 months to this SLEP's discussions.

jnothman commented 1 year ago

Merging, because I can.