search

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

slep019: Add non-core-dev contributors to an ack section #82

Closed adrinjalali closed 1 year ago

adrinjalali commented 1 year ago

I think something which we haven't done so far, but would be nice to do, is to acknowledge people who contribute to the development of a slep, but are not core contributors.

I'm not sure of the text, or whom to include/exclude, but I thought I could open a PR and see how y'all feel about it. I've included Reshama and Lucy as well since at the time of writing the slep, they're not a part of the to-be-formed "core contributor" team.

I haven't added @cmarmo here since she's an author with #81 on the slep.

So, WDYT?

cmarmo commented 1 year ago

I'm more than happy to cite and thank all the contributors to the discussion.

I've included Reshama and Lucy as well since at the time of writing the slep, they're not a part of the to-be-formed "core contributor" team.

As the to-be-formed team is not yet formed nobody knows who will be in it or not... right? It can be wise to be as more inclusive as possible.... If all contributors not belonging to the current core team should be aknowledged then Tim should be added to the list.