search

scikit-learn / enhancement_proposals

Enhancement proposals for scikit-learn: structured discussions and rational for large additions and modifications
https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
48 stars 34 forks source link

SLEP020: Simplifing Governance Changes #84

Closed thomasjpfan closed 1 year ago

thomasjpfan commented 1 year ago

This SLEP proposes to permit governance changes through GitHub Pull Requests, where a vote will also occur in the Pull Request.

Through the discussions in https://github.com/scikit-learn/enhancement_proposals/pull/74 and https://github.com/scikit-learn/enhancement_proposals/pull/81, I think we agree with moving governance changes to PRs. Fundamentally, this SLEP is a subset of SLEP019, but I think this SLEP will enable us to move more efficiently and make other changes, as discussed in SLEP019.

The last version of this SLEP is rendered online: https://scikit-learn-enhancement-proposals--84.org.readthedocs.build/en/84/slep020/proposal.html

lorentzenchr commented 1 year ago

I think we can merge and call for a vote, right?

jjerphan commented 1 year ago

I think we can merge and call for a vote, right?

I think people might not have seen this SLEP, yet might want to participate in its edition.

In order not to invalidate the vote with edition during its period, what if we define an end of edition for this first draft, iterate until the end of the edition, merge this draft, and call for a vote?

What do you think?

thomasjpfan commented 1 year ago

I am planning to merge on Friday January 20 and calling for a vote at the same time.

jjerphan commented 1 year ago

Should we reference all the links in the body of the SLEP in the dedicated "References and Footnotes" section instead?

reshamas commented 1 year ago

Should we reference all the links in the body of the SLEP in the dedicated "References and Footnotes" section instead?

either, or. Some links are more important and maybe would be helpful to have in the body of the text.

jjerphan commented 1 year ago

The SLEP is rendered online here (I have added this to the description of this PR).

Due to the concision of the SLEP, I think links are relatively accessible if they are in the section. One can also provide context in this section' entries. But that's mostly a nitpick from me.