improvements in naive_bayes

scikit-learn / scikit-learn

scikit-learn: machine learning in Python

https://scikit-learn.org

BSD 3-Clause "New" or "Revised" License

59.48k stars 25.28k forks source link

improvements in naive_bayes #108

Closed fabianp closed 12 years ago

fabianp commented 13 years ago

across the whole module estimated parameters do not end with underscore
- non-standard names are used for some variables, like unique_y (called classes in SGD and labels in SVM), we should think about unifying these.

larsmans commented 13 years ago

I'd go for labels. By the estimated parameters, do you mean proba_y, theta and sigma? Wouldn't changing those break pickle'd GNB instances?

larsmans commented 13 years ago

Commit d7e64beb01682e5dc006b4af33f76b48c280f1ce introduced some changes to Gaussian Naive Bayes, but more work remains to be done. It would be elegant to reformulate GNB as a linear classifier, just like Multinomial NB.

amueller commented 12 years ago

@fabianp do you think the issue is resolved? Or is there something else to do?

amueller commented 12 years ago

The unique_y was also fixed at some point, classes_ is now used everywhere as far as I can tell. I hope #890 will help unify things even more.