search

scikit-learn / scikit-learn

scikit-learn: machine learning in Python
https://scikit-learn.org
BSD 3-Clause "New" or "Revised" License
59.57k stars 25.3k forks source link

LDA bugfix #5092 lost in refactoring #5679

Closed cbrnr closed 8 years ago

cbrnr commented 8 years ago

I noticed that #5092 did not make it into the refactored code in discriminant_analysis.py (line 58).

amueller commented 8 years ago

Thanks for pointing that out!

amueller commented 8 years ago

I wonder how that passed the regression test. I guess that was also lost...

amueller commented 8 years ago

See #5680

cbrnr commented 8 years ago

I think more things were discarded in the refactoring process. I checked the commit history and e.g. #5216 didn't make it either...

amueller commented 8 years ago

Hm that is no good. We need to check that.

amueller commented 8 years ago

(removing the blocker as the release critical part has been merged)

cbrnr commented 8 years ago

@amueller all changes seem to be there now, so I guess this issue can be closed?

amueller commented 8 years ago

is #5216 there? I didn't do anything about that.

cbrnr commented 8 years ago

Yes, it's there.

lesteve commented 8 years ago

@amueller from the discussion, it looks like this one can be closed. Do you remember something about this?

amueller commented 8 years ago

true, thanks