scikit-tda / DREiMac

Dimensionality Reduction with Eilenberg-MacLane Coordinates
Apache License 2.0
39 stars 13 forks source link

[JOSS] Software references in paper #11

Closed mtsch closed 1 year ago

mtsch commented 1 year ago

Hi, first of all thanks for the well-written paper and great software! I love the detailed documentation with lots of examples, and how intuitive and easy to use it is.

I have a small comment regarding citing other software that you build upon. In particular, I think you should mention Ripser and Ripser.py as those are crucial to quickly computing persistent cohomology used to find circular coordinates. It might also be worth mentioning other software you use that has papers written on them (I could find papers on numba, matplotlib and numpy, you can decide which of these you want to include).

On a related note, my software package Ripserer also implements (a more limited form of) sparse circular coordinates. I understand that's easy to miss as I never advertised it and it is somewhat hidden in the docs. You could mention it alongside Dionysus in the statement of need.

Ref. #5791

ctralie commented 1 year ago

Thanks for the feedback! Very interesting that you had your own implementation of sparse circular coordinates! We can certainly link to that from our documentation

On Mon, Oct 2, 2023 at 9:13 PM mtsch @.***> wrote:

Hi, first of all thanks for the well-written paper and great software! I love the detailed documentation with lots of examples, and how intuitive and easy to use it is.

I have a small comment regarding citing other software that you build upon. In particular, I think you should mention Ripser and Ripser.py as those are crucial to quickly computing persistent cohomology used to find circular coordinates. It might also be worth mentioning other software you use that has papers written on them (I could find papers on numba, matplotlib and numpy, you can decide which of these you want to include).

On a related note, my software package Ripserer also implements (a more limited form of) sparse circular coordinates. I understand that's easy to miss as I never advertised it and it is somewhat hidden in the docs https://mtsch.github.io/Ripserer.jl/dev/api/#Ripserer.CircularCoordinates. You could mention it alongside Dionysus in the statement of need.

Ref. #5791 https://github.com/openjournals/joss-reviews/issues/5791

— Reply to this email directly, view it on GitHub https://github.com/scikit-tda/DREiMac/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWDZRGYQ3DBBA5CEY6RH3X5NREZAVCNFSM6AAAAAA5QG7XR2VHI2DSMVQWIX3LMV43ASLTON2WKOZRHEZDGMBZGU3TEOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

LuisScoccola commented 1 year ago

Hi, thank you for the feedback! Please see the latest version of the paper and let us know if we have missed anything.

mtsch commented 1 year ago

Thanks, looks good to me now!