search

scikit-tda / DREiMac

Dimensionality Reduction with Eilenberg-MacLane Coordinates
Apache License 2.0
37 stars 13 forks source link

Coordinates on new points #14

Open wreise opened 11 months ago

wreise commented 11 months ago

Implements #9 : circular and toroidal coordinates on new points.

To-do:

LuisScoccola commented 11 months ago

Thank you for starting this, @wreise! And sorry for the late reply. This looks quite promising. I ask that you also please add tests (maybe this can be another item in your to-do). As a heads-up: there will be a few minor changes pushed to main soon, which will require rebasing (see #13).

I see that this is a draft for now, do you want me to check anything specific or wait until further progress is done?

Thanks again for your contribution!

codecov[bot] commented 11 months ago

Codecov Report

Merging #14 (dfdc540) into master (9ced70d) will decrease coverage by 0.23%. The diff coverage is 63.63%.

:exclamation: Current head dfdc540 differs from pull request most recent head 470e450. Consider uploading reports for the commit 470e450 to get more accurate results

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   72.64%   72.42%   -0.23%     
==========================================
  Files          10       10              
  Lines        1053     1059       +6     
  Branches      189      191       +2     
==========================================
+ Hits          765      767       +2     
- Misses        269      271       +2     
- Partials       19       21       +2
Files Coverage Δ
dreimac/circularcoords.py 100.00% <ø> (ø)
dreimac/emcoords.py 84.72% <75.00%> (-2.05%) :arrow_down:
dreimac/toroidalcoords.py 96.02% <33.33%> (-1.11%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

wreise commented 11 months ago

I ask that you also please add tests

I forgot to commit the tests. Could you perhaps just trigger the automated tests on the newest commit?

As a heads-up: there will be a few minor changes pushed to main soon, which will require rebasing

Noted!

I'm afraid that the projective coordinates will have to wait a bit: I will probably un-draft the PR when I have a version of those.