scikit-tda / DREiMac

Dimensionality Reduction with Eilenberg-MacLane Coordinates
Apache License 2.0
37 stars 13 forks source link

Convert to pyproject.toml spec #18

Closed catanzaromj closed 1 week ago

catanzaromj commented 2 weeks ago

This PR converts DREiMac to using the pyproject.toml style of specification, as wheel as using setuptools for building wheels.

@LuisScoccola Please double check the email addresses, license, keywords and urls specificed in the pyproject.toml file.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.57%. Comparing base (ca37386) to head (b5e6a16).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #18 +/- ## ======================================= Coverage 72.57% 72.57% ======================================= Files 10 10 Lines 1050 1050 Branches 189 189 ======================================= Hits 762 762 Misses 269 269 Partials 19 19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LuisScoccola commented 1 week ago

Thanks a lot @catanzaromj, this is great! I confirm email addresses, license, keywords and urls look good.

@ctralie, do you want to take a look before I merge to master?

LuisScoccola commented 1 week ago

One comment is that CHANGELOG.md is not really being used. Should we keep it in pyproject.toml?

catanzaromj commented 1 week ago

@LuisScoccola Makes sense. I removed it from pyproject.toml.

ctralie commented 1 week ago

Thanks a lot @catanzaromj, this is great! I confirm email addresses, license, keywords and urls look good.

@ctralie, do you want to take a look before I merge to master?

All good by me, thank you so much for helping to maintain this!