scikit-tda / cechmate

Custom filtration constructors for Python
http://cechmate.scikit-tda.org
MIT License
22 stars 11 forks source link

Extended persistence #3

Closed sauln closed 5 years ago

sauln commented 5 years ago

This PR has an implementation of the extended persistence.

It still needs some massaging, but the general process works on the few examples I've cooked up (see test_extended.py.

I would love it if anyone gave some feedback or did a code review.

TODO still:

codecov[bot] commented 5 years ago

Codecov Report

Merging #3 into master will increase coverage by 12.12%. The diff coverage is 88.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #3       +/-   ##
===========================================
+ Coverage   79.61%   91.73%   +12.12%     
===========================================
  Files          10       12        +2     
  Lines         309      375       +66     
===========================================
+ Hits          246      344       +98     
+ Misses         63       31       -32
Impacted Files Coverage Δ
cechmate/filtrations/custom.py 0% <0%> (ø)
cechmate/__init__.py 100% <100%> (ø) :arrow_up:
cechmate/solver.py 97.36% <100%> (-0.04%) :arrow_down:
cechmate/utils.py 100% <100%> (ø)
cechmate/filtrations/__init__.py 100% <100%> (ø) :arrow_up:
cechmate/filtrations/extended.py 95.69% <95.69%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e6feab...e7b6bfe. Read the comment docs.