search

scikit-tda / cechmate

Custom filtration constructors for Python
http://cechmate.scikit-tda.org
MIT License
22 stars 11 forks source link

Maxdim #8

Closed ctralie closed 5 years ago

ctralie commented 5 years ago

Fixing maxdim naming across all filtrations (and actually making it accessible). Also restoring plots in basic usage notebook

codecov[bot] commented 5 years ago

Codecov Report

Merging #8 into master will increase coverage by 1.18%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   91.73%   92.91%   +1.18%     
==========================================
  Files          12       12              
  Lines         375      381       +6     
==========================================
+ Hits          344      354      +10     
+ Misses         31       27       -4
Impacted Files Coverage Δ
cechmate/_version.py 100% <100%> (ø) :arrow_up:
cechmate/filtrations/base.py 72.72% <100%> (ø) :arrow_up:
cechmate/filtrations/alpha.py 95.45% <100%> (+6.81%) :arrow_up:
cechmate/filtrations/rips.py 96.66% <75%> (-3.34%) :arrow_down:
cechmate/filtrations/cech.py 95.23% <75%> (-4.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ed1493...6d058e9. Read the comment docs.