search

scikit-tda / kepler-mapper

Kepler Mapper: A flexible Python implementation of the Mapper algorithm.
https://kepler-mapper.scikit-tda.org
MIT License
623 stars 180 forks source link

Update code to new cover api #229

Closed erooke closed 2 years ago

erooke commented 3 years ago

The getting started page, many examples, and test/benchmark.py all contained mentions of an older api where mapper.map was called with nr_cubes and perc_overlap instead of being supplied a Cover object. This pull request aims to update these references.

codecov[bot] commented 2 years ago

Codecov Report

Merging #229 (0101e2c) into master (7dc4d0a) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 0101e2c differs from pull request most recent head 7c3237b. Consider uploading reports for the commit 7c3237b to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files          11       11           
  Lines         862      862           
  Branches      189      189           
=======================================
  Hits          692      692           
  Misses        138      138           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7dc4d0a...7c3237b. Read the comment docs.

deargle commented 2 years ago

Thanks again @erooke!