scikit-tda / kepler-mapper

Kepler Mapper: A flexible Python implementation of the Mapper algorithm.
https://kepler-mapper.scikit-tda.org
MIT License
629 stars 182 forks source link

Updated deprecated numpy function in visuals.py #255

Closed ulriks9 closed 2 months ago

ulriks9 commented 3 months ago

np.asscalar() is deprecated as of numpy version 1.16. I updated this code to use np.ndarray.item() instead of np.asscalar()

blue-j commented 3 months ago

Nice catch! I just submitted #254 for the same problem. We should compare our solutions, I am always learning.

catanzaromj commented 2 months ago

@ulriks9 Thank you for the PR. It turns out this fix was already implemented on a branch just merged into master.