Closed alperenkaran closed 2 years ago
Fantastic! Thank you for the example!
On Sun, Jun 12, 2022 at 10:45 AM alperenkaran @.***> wrote:
Hello, and thank you for the great library!
Inspired by the paper “confidence sets for persistence diagrams” ( https://arxiv.org/pdf/1303.7117.pdf), the eyeglasses shape replicates and generalizes the shape given in the paper (fig.8). You can use arbitrary radii, and specify the neck size.
Note: This is my very first pull request :)
You can view, comment on, or merge this pull request online at:
https://github.com/scikit-tda/tadasets/pull/13 Commit Summary
- deb42f6 https://github.com/scikit-tda/tadasets/pull/13/commits/deb42f64ad524d6a3758c6a6e2062382fafefeb6 added eyeglasses shape
File Changes
(3 files https://github.com/scikit-tda/tadasets/pull/13/files)
- M README.md https://github.com/scikit-tda/tadasets/pull/13/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 (2)
- M tadasets/shapes.py https://github.com/scikit-tda/tadasets/pull/13/files#diff-029925660193a51a75d04d2b5b21c86f5200252f30d900b80f37ed0eac9a74fa (78)
- M test/test_shapes.py https://github.com/scikit-tda/tadasets/pull/13/files#diff-b856bfd7433978964b9bce100ba73b13abcfd2274f46318631c04d62adadb264 (19)
Patch Links:
- https://github.com/scikit-tda/tadasets/pull/13.patch
- https://github.com/scikit-tda/tadasets/pull/13.diff
— Reply to this email directly, view it on GitHub https://github.com/scikit-tda/tadasets/pull/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWDZVG7MGPQLH4AZQUDLLVOXZWZANCNFSM5YR3AKEA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Hello @ctralie ! I was wondering if I have to do anything else after the pull request? I am excited about my first contribution to a project :)
Thank you for reminding me to merge this, and for your contribution!
Hello, and thank you for the great library!
Inspired by the paper “confidence sets for persistence diagrams” (https://arxiv.org/pdf/1303.7117.pdf), the eyeglasses shape replicates and generalizes the shape given in the paper (fig.8). You can use arbitrary radii, and specify the neck size.
Note: This is my very first pull request :)