scikit-tda / tadasets

Synthetic data sets apt for Topological Data Analysis
http://tadasets.scikit-tda.org
MIT License
34 stars 7 forks source link

Eyeglasses shape #13

Closed alperenkaran closed 2 years ago

alperenkaran commented 2 years ago

Hello, and thank you for the great library!

Inspired by the paper “confidence sets for persistence diagrams” (https://arxiv.org/pdf/1303.7117.pdf), the eyeglasses shape replicates and generalizes the shape given in the paper (fig.8). You can use arbitrary radii, and specify the neck size.

Note: This is my very first pull request :)

ctralie commented 2 years ago

Fantastic! Thank you for the example!

On Sun, Jun 12, 2022 at 10:45 AM alperenkaran @.***> wrote:

Hello, and thank you for the great library!

Inspired by the paper “confidence sets for persistence diagrams” ( https://arxiv.org/pdf/1303.7117.pdf), the eyeglasses shape replicates and generalizes the shape given in the paper (fig.8). You can use arbitrary radii, and specify the neck size.

Note: This is my very first pull request :)

You can view, comment on, or merge this pull request online at:

https://github.com/scikit-tda/tadasets/pull/13 Commit Summary

File Changes

(3 files https://github.com/scikit-tda/tadasets/pull/13/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/scikit-tda/tadasets/pull/13, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWDZVG7MGPQLH4AZQUDLLVOXZWZANCNFSM5YR3AKEA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

alperenkaran commented 2 years ago

Hello @ctralie ! I was wondering if I have to do anything else after the pull request? I am excited about my first contribution to a project :)

ctralie commented 2 years ago

Thank you for reminding me to merge this, and for your contribution!