scikit-tda / tadasets

Synthetic data sets apt for Topological Data Analysis

http://tadasets.scikit-tda.org

MIT License

34 stars 7 forks source link

Add random seed to shape constructors #7

Closed catanzaromj closed 3 years ago

catanzaromj commented 3 years ago

Raised in https://github.com/scikit-tda/tadasets/issues/5, this adds a random seed parameter to the shape constructors. This change is easy enough to implement in the other methods of the package if desired. I found setting the random seed to be especially useful for benchmarking my own code and thought others might benefit from it as well.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@05af7cd). Click here to learn what that means. The diff coverage is 90.00%.

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage          ?   86.92%           
=========================================
  Files             ?        6           
  Lines             ?      153           
  Branches          ?       13           
=========================================
  Hits              ?      133           
  Misses            ?       15           
  Partials          ?        5

Impacted Files	Coverage Δ
tadasets/shapes.py	`69.69% <90.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05af7cd...c29678c. Read the comment docs.

sauln commented 3 years ago

This is great, thank you! It looks like the travis tests are a bit backed up, maybe travis is having some availability issues? Once they are done I see no reason not to merge this.

ctralie commented 3 years ago

Yup, this is great. I didn't realize we didn't already incorporate seeds, so thanks for noticing that!

On Wed, Nov 11, 2020 at 1:23 PM Nathaniel Saul notifications@github.com wrote:

This is great, thank you! It looks like the travis tests are a bit backed up, maybe travis is having some availability issues? Once they are done I see no reason not to merge this.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/scikit-tda/tadasets/pull/7#issuecomment-725584251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWDZR3AEYXIS6UUNFQTADSPLI77ANCNFSM4TSH5COA .