search

scikit-umfpack / scikit-umfpack-wheels

1 stars 3 forks source link

How to update for a new scikit-umfpack release? #2

Open rc opened 6 years ago

rc commented 6 years ago

@matthew-brett could you refresh my memory, please? The description in the README holds for SciPy, right?

matthew-brett commented 6 years ago

I did a PR just now for some maintenance:

https://github.com/scikit-umfpack/scikit-umfpack-wheels/pull/3

In there, I upated the README to refer to scikit-umfpack instead of Scipy.

The basic procedure is there. I would:

To get started. Let me know if I can help.

rc commented 6 years ago

Thanks! I have merged #3.

I have cloned my fork https://github.com/rc/scikit-umfpack-wheels and created a branch called scikit-umfpack-0.3.2 to work in.

Now some things are still not clear to me:

Thanks!

matthew-brett commented 6 years ago

There is a scikit-umfpack submodule - should I pull the current scikit-umfpack sources there manually?

No need, BUILD_COMMIT dictates the commit to checkout for the build.

I can see BUILD_COMMIT in .travis.yml, but not in appveyor.yml.

Oops - no. I don't think I set appveyor up there, but have a look at https://github.com/scikit-image/scikit-image-wheels/blob/master/.appveyor.yml ; search for BUILD_COMMIT for the extra lines you need.

After I set BUILD_COMMIT to the scikit-umfpack release commit, I create a PR here using the scikit-umfpack-0.3.2 - this will trigger the build?

Yes, it should.

rc commented 6 years ago

Thanks! I have created #4, where I tried to update appveyor.yml according to your link.

rc commented 5 years ago

@matthew-brett, in #4 all tests pass, but I do not see the wheels - what am I doing wrong? Should I merge the PR first?

matthew-brett commented 5 years ago

The build says

WARNING: secret API key missing: skipping package upload

I guess, that it might be building from your repo, and therefore the key would not match, as it is encrypted against the main repo? So maybe, yes, try merging.

rc commented 5 years ago

@matthew-brett thanks! But the missing key problem persists also for the master on the main repo after merging #4. I will check the problem later - any hints in the meantime will be appreciated!

matthew-brett commented 5 years ago

Try #5?

rc commented 5 years ago

Looks good! But for some reason, it seems to be 0.3.1? I have re-checked the BUILD_COMMIT and it points correctly to the 0.3.2 release.

$ python -m wheelhouse_uploader upload --local-folder ${TRAVIS_BUILD_DIR}/wheelhouse/ $UPLOAD_ARGS $CONTAINER
About to upload 1 files
Uploading /home/travis/build/scikit-umfpack/scikit-umfpack-wheels/wheelhouse/scikit_umfpack-0.3.1-cp27-cp27mu-manylinux1_x86_64.whl [9.453 MB]
Uploading metadata.json with 4663 entries
Wheelhouse successfully published at:
http://a365fff413fe338398b6-1c8a9b3114517dc5fe17b7c3f8c63a43.r19.cf2.rackcdn.com
rc commented 5 years ago

@matthew-brett many thanks! The 0.3.2 wheels seems to work now - I have just tried a testpypi installation. Uploading to pypi...

rc commented 5 years ago

Now I have tried to (re)enable Appveyor to build the windows wheels - those can be found in the artifacts tab but the tests fail (see the console output). So the appveyor.yml file probably needs fixing too. It was originally written by a developer who is currently a ghost, so any further help would be appreciated. (I do not have access to a windows machine right now to verify that the wheels are really not working).