PEP 518 support (pyproject.toml) should build against oldest supported numpy

scikit-umfpack / scikit-umfpack

The umfpack scikit provides wrapper of UMFPACK sparse direct solver to SciPy.

BSD 3-Clause "New" or "Revised" License

45 stars 27 forks source link

PEP 518 support (pyproject.toml) should build against oldest supported numpy #40

Open rgommers opened 6 years ago

rgommers commented 6 years ago

See https://github.com/scikit-umfpack/scikit-umfpack/pull/38#issuecomment-332453263

The pyproject.toml file should look similar to the SciPy one, where for each Python version the lowest supported numpy version is built against. This doesn't quite work right now with pip 10.0.0.dev0. Investigate before the next release and fix either here or report issue on the pip issue tracker.

rgommers commented 6 years ago

@rc I can't assign myself but feel free to assign to me and ping me when you're planning a release. (will have more time after SciPy 1.0 is out the door).

rc commented 6 years ago

Thanks for creating this issue. (pyproject.toml is a new thing for me)

rgommers commented 6 years ago

Should look like:

"numpy==1.8.2; python_version<='3.4'",
"numpy==1.9.3; python_version=='3.5'",
"numpy==1.12.1; python_version=='3.6'",
"numpy==1.13.1; python_version>='3.7'",

Also need to add the correct install_requires in setup.py. Next release will require SciPy 1.0