scilus / scilpy

The Sherbrooke Connectivity Imaging Lab (SCIL) Python dMRI processing toolbox
Other
60 stars 60 forks source link

[FIX] Typo in scil_dti_metrics script #1000

Closed AlexVCaron closed 3 months ago

AlexVCaron commented 3 months ago

Quick description

scil_dti_metrics.py is unusable due to a typo in the script. I assume in the tests and most usages, we ask to output FA, and it must be why we didn't detect this error, since or shortcuts evaluating args.RGB.

...

Type of change

Check the relevant options.

Provide data, screenshots, command line to test (if relevant)

...

Checklist

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.27%. Comparing base (4e7047d) to head (0f4d6e0). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1000 +/- ## ========================================== + Coverage 68.24% 68.27% +0.02% ========================================== Files 419 419 Lines 21391 21391 Branches 3209 3209 ========================================== + Hits 14599 14604 +5 + Misses 5530 5528 -2 + Partials 1262 1259 -3 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1000/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1000/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.25% <100.00%> (+0.03%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1000/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `66.86% <ø> (ø)` | |
EmmaRenauld commented 3 months ago

P.s. Numero 1000!!!!