arnaudbore commented 3 months ago

Quick description

First MRDS script - use MRDS output and NUFO like image and select the expected solutions.

...

Type of change

Check the relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

data

Command line:

scil_mrds_select_number_of_tensors.py sub-01 nufo.nii.gz

Checklist

[ ] My code follows the style guidelines of this project (run autopep8)
[ ] I added relevant citations to scripts, modules and functions docstrings and descriptions
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I moved all functions from the script file (except the argparser and main) to scilpy modules
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

pep8speaks commented 3 months ago

Hello @arnaudbore, Thank you for updating !

In the file scripts/scil_mrds_select_number_of_tensors.py:

Line 20:80: E501 line too long (82 > 79 characters) Line 74:80: E501 line too long (84 > 79 characters) Line 77:80: E501 line too long (80 > 79 characters) Line 80:80: E501 line too long (88 > 79 characters) Line 89:80: E501 line too long (94 > 79 characters) Line 97:80: E501 line too long (86 > 79 characters) Line 100:80: E501 line too long (82 > 79 characters)

Comment last updated at 2024-11-13 20:12:15 UTC

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 98.59155% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.03%. Comparing base (8339116) to head (5a6a2bd). Report is 36 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1021 +/- ## ========================================== + Coverage 68.94% 69.03% +0.09% ========================================== Files 434 435 +1 Lines 22657 22728 +71 Branches 3080 3086 +6 ========================================== + Hits 15621 15691 +70 Misses 5724 5724 - Partials 1312 1313 +1 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1021/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1021/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.83% <98.59%> (+0.15%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1021/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `67.91% <ø> (ø)` | |

scilus / scilpy