frheault commented 3 months ago

Quick description

Simple script to compute the minimum distance between two masks. This could be useful to compute a lesion to bundle distance to create a NIFTI image and then color a bundle. (The white sphere is a , rendered in 3D in MI-Brain, it was initially a binary mask.

...

Type of change

Check the relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

[x] My code follows the style guidelines of this project (run autopep8)
[ ] I added relevant citations to scripts, modules and functions docstrings and descriptions
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I moved all functions from the script file (except the argparser and main) to scilpy modules
[x] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

pep8speaks commented 3 months ago

Hello @frheault, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-08-22 18:39:09 UTC

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.71%. Comparing base (9ab3ce4) to head (a8bbb9f). Report is 13 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1023 +/- ## ========================================== + Coverage 68.66% 68.71% +0.05% ========================================== Files 428 429 +1 Lines 22209 22253 +44 Branches 3319 3321 +2 ========================================== + Hits 15250 15292 +42 - Misses 5673 5674 +1 - Partials 1286 1287 +1 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1023/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1023/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.63% <100.00%> (+0.05%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1023/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `67.42% <100.00%> (+0.04%)` | :arrow_up: |