scilus / scilpy

The Sherbrooke Connectivity Imaging Lab (SCIL) Python dMRI processing toolbox
Other
62 stars 60 forks source link

Update test data key to 'tractograms.zip' instead of 'atlas.zip' #1024

Closed elyz081 closed 2 months ago

elyz081 commented 3 months ago

Quick description

The test was failing due to fetching the wrong dataset ('atlas.zip') instead of the intended 'tractograms.zip'. I updated the fetch_data key to fetch 'tractograms.zip' instead of 'atlas.zip'.

Type of change

Check the relevant options.

Provide data, screenshots, command line to test (if relevant)

Checklist

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 94.56522% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (460dac8) to head (343f7fe). Report is 36 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1024 +/- ## ========================================== + Coverage 68.61% 68.73% +0.11% ========================================== Files 426 430 +4 Lines 21835 22276 +441 Branches 3267 3327 +60 ========================================== + Hits 14982 15311 +329 - Misses 5578 5678 +100 - Partials 1275 1287 +12 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1024/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1024/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.62% <92.42%> (-0.31%)` | :arrow_down: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1024/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `67.47% <100.00%> (+0.76%)` | :arrow_up: |
frheault commented 3 months ago

It seems like you created a branch from another branch (antoine's) instead of going back to master before creating it.

You can see a fee of Antoine's commit before yours., it should only be a single commit. Proposed solution: Close this PR, create a branch (from master), and redo the change, commit+push.

frheault commented 3 months ago

@arnaudbore It seems like the error is unrelated to the PR, am I crazy?

(Sorry about closing and opening, misclicked)