frheault commented 3 months ago

Quick description

Script to compute NAWM around a binary lesion mask OR a lesion labels map. This output image(s) that will look like rings around each lesion. ...

Type of change

Check the relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

[x] My code follows the style guidelines of this project (run autopep8)
[ ] I added relevant citations to scripts, modules and functions docstrings and descriptions
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I moved all functions from the script file (except the argparser and main) to scilpy modules
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

pep8speaks commented 3 months ago

Hello @frheault, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-10-11 15:07:13 UTC

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 69.87952% with 25 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (f690978) to head (2ce4f62). Report is 15 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1026 +/- ## ======================================= Coverage 68.79% 68.79% ======================================= Files 431 432 +1 Lines 22372 22455 +83 Branches 3024 3039 +15 ======================================= + Hits 15390 15448 +58 - Misses 5695 5709 +14 - Partials 1287 1298 +11 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1026/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1026/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.66% <61.40%> (-0.04%)` | :arrow_down: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1026/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `67.56% <88.46%> (+0.05%)` | :arrow_up: |

scilus / scilpy