scilus / scilpy

The Sherbrooke Connectivity Imaging Lab (SCIL) Python dMRI processing toolbox
Other
62 stars 60 forks source link

return option min_vol_lesion #1036

Closed ThoumyreStanislas closed 1 month ago

ThoumyreStanislas commented 1 month ago

Quick description

I've put the min_lesion_volume option back in because the script doesn't work without it and the problem is that if I remove the option, the compute_lesion_stats script in scilpy.utils.metrics_tools takes a default value of 7mm without being able to change it. so we'll just have to make sure for now that when we use this script after scil_label_from_mask.py we keep the same minimum volume between the two scripts.

Type of change

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.79%. Comparing base (a07a8ec) to head (ebfcd34). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1036 +/- ## ======================================= Coverage 68.79% 68.79% ======================================= Files 432 432 Lines 22455 22456 +1 Branches 3039 3038 -1 ======================================= + Hits 15448 15449 +1 Misses 5709 5709 Partials 1298 1298 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1036/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1036/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.66% <100.00%> (+<0.01%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1036/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `67.56% <ø> (ø)` | |