AntoineTheb commented 4 weeks ago

Quick description

This PR improves bundle endpoint maps computation. Before, the map was only computed on streamline points exactly, which may be problematic if the step size is too large (see fig. 1 for ref). Now, the map includes every voxel traversed by the endpoints (however many points are selected). Moreover, the user can now select n millimeters instead of points, which makes much more sense when dealing with compressed streamlines.

Breaking change: the arguments of scil_bundle_compute_endpoint_maps.py are now slightly different.

Type of change

Check the relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

Fig 1.: Before, 3 points

Fig. 2: After, 3 points

Fig. 3: After, 10mm.

Checklist

[X] My code follows the style guidelines of this project (run autopep8)
[X] I added relevant citations to scripts, modules and functions docstrings and descriptions
[X] I have performed a self-review of my code
[X] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[X] I moved all functions from the script file (except the argparser and main) to scilpy modules
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

pep8speaks commented 4 weeks ago

Hello @AntoineTheb, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-11-08 16:17:31 UTC

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.89%. Comparing base (81765a2) to head (dd88f79). Report is 97 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1047 +/- ## ========================================== + Coverage 68.79% 68.89% +0.10% ========================================== Files 432 434 +2 Lines 22454 22646 +192 Branches 3041 3078 +37 ========================================== + Hits 15448 15603 +155 - Misses 5706 5727 +21 - Partials 1300 1316 +16 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1047/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1047/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.61% <100.00%> (-0.06%)` | :arrow_down: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1047/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `67.89% <100.00%> (+0.33%)` | :arrow_up: |

scilus / scilpy