scilus / scilpy

The Sherbrooke Connectivity Imaging Lab (SCIL) Python dMRI processing toolbox
Other
62 stars 60 forks source link

FIX: `ratio` arg in volume pairwise comparison #1051

Closed AntoineTheb closed 2 weeks ago

AntoineTheb commented 2 weeks ago

Quick description

A bug in a function call inverted the behavior of the --ignore_zeros_in_BA and --ratio parameters in scil_volume_pairwise_comparison.py

Type of change

Check the relevant options.

Provide data, screenshots, command line to test (if relevant)

Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.93%. Comparing base (48d606d) to head (a75ee6a). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1051 +/- ## ======================================= Coverage 68.92% 68.93% ======================================= Files 438 438 Lines 22889 22889 Branches 3106 3106 ======================================= + Hits 15777 15779 +2 + Misses 5794 5793 -1 + Partials 1318 1317 -1 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1051/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.84% <ø> (+0.01%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1051/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `67.65% <ø> (ø)` | |