arnaudbore commented 1 week ago

Quick description

Here is some data to test everything: https://www.dropbox.com/scl/fo/rtchki2wiirwe15buuo4r/ABGJ-7I3l9V2sIZkpTveBBI?rlkey=nmlwq2zpfbf59it8i6m6cr485&dl=0

Resampling

scil_volume_resample.py a107__dwi_n4.nii.gz a107__dwi_n4_resampled_w.nii.gz --voxel_size 0.05 --interp lin -v -f

Tracking with non iso voxel (1e-3)

algo=prob
npv=1
step=0.05
theta=20
sub=1
rk=1
min_L=8
max_L=9

scil_tracking_local_dev.py a107__fodf.nii.gz a107_all_SSp-m_LR.nii.gz a107_SSp-m_CC_body-genu_LR_dil1.nii.gz toto.trk  --algo ${algo} --npv ${npv} --step ${step} --theta ${theta} --sub_sphere ${sub} --rk_order ${rk} --min_length ${min_L} --max_length ${max_L} --process 6 -v -f

Type of change

Check the relevant options.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

[x] My code follows the style guidelines of this project (run autopep8)
[x] I added relevant citations to scripts, modules and functions docstrings and descriptions
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I moved all functions from the script file (except the argparser and main) to scilpy modules
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

pep8speaks commented 1 week ago

Hello @arnaudbore, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-11-26 16:05:29 UTC

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@e5acccc). Learn more about missing BASE report.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1055 +/- ## ========================================= Coverage ? 68.59% ========================================= Files ? 445 Lines ? 23897 Branches ? 3256 ========================================= Hits ? 16391 Misses ? 6156 Partials ? 1350 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1055/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1055/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `69.93% <35.71%> (?)` | | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1055/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `66.77% <ø> (?)` | |

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

scilus / scilpy

[ENH] Fix resample local_tracking_dev accepts close iso voxels #1055