AlexVCaron commented 1 week ago

Quick description

Add parameter to specify floating point precision of fiber response functions at saving, using the fmt parameter of np.savetxt.

...

Type of change

Check the relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

[x] My code follows the style guidelines of this project (run autopep8)
[x] I added relevant citations to scripts, modules and functions docstrings and descriptions
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I moved all functions from the script file (except the argparser and main) to scilpy modules
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

pep8speaks commented 1 week ago

Hello @AlexVCaron, Thank you for updating !

In the file scripts/tests/test_frf_mean.py:

Line 48:13: E117 over-indented Line 49:55: W291 trailing whitespace

In the file scripts/tests/test_frf_set_diffusivities.py:

Line 53:51: W291 trailing whitespace

Comment last updated at 2024-11-26 23:04:10 UTC

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (master@e5acccc). Learn more about missing BASE report. Report is 42 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1057 +/- ## ========================================= Coverage ? 69.34% ========================================= Files ? 446 Lines ? 23920 Branches ? 3264 ========================================= Hits ? 16587 Misses ? 5948 Partials ? 1385 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/1057/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/1057/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `70.15% <100.00%> (?)` | | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/1057/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `68.25% <100.00%> (?)` | |

scilus / scilpy