karanphil commented 7 months ago

Quick description

I added multi-shell support to scil_frf_set_diffusivities.py. It only took a few modifcations, and single-shell works as before. This was added with the goal of running it in nf-scil. I added tests also, and a check on the format of the input new_frf.

...

Type of change

Check the relevant options.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

[x] My code follows the style guidelines of this project (run autopep8)
[x] I added relevant citations to scripts, modules and functions docstrings and descriptions
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I moved all functions from the script file (except the argparser and main) to scilpy modules
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

pep8speaks commented 7 months ago

Hello @karanphil, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-02-14 16:49:27 UTC

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (82b98a1) 65.92% compared to head (dedb657) 65.92%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #896 +/- ## ======================================= Coverage 65.92% 65.92% ======================================= Files 384 384 Lines 21331 21337 +6 Branches 3491 3492 +1 ======================================= + Hits 14063 14067 +4 - Misses 5664 5665 +1 - Partials 1604 1605 +1 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/896/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/896/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `∅ <ø> (∅)` | | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/896/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `∅ <ø> (∅)` | |

scilus / scilpy