Second attempt at uniformizing the verbose option. I added this line: logging.getLogger().setLevel(logging.getLevelName(args.verbose)) to all scripts, and modified the way the verbose argument is used (in scilpy.io.utils). I also cleaned a bit some modules, so when there was only debug logging, they are now info logging.
There might be some scripts like scil_dwi_compute_snr.py that used logging.info to print some results, but with the new default as warning, they won't work properly without -v. I don't know all the script in scilpy so I would need some help to know if I broke anything. :)
...
Type of change
Check the relevant options.
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update
Provide data, screenshots, command line to test (if relevant)
...
Checklist
[ ] My code follows the style guidelines of this project (run autopep8)
[ ] I added relevant citations to scripts, modules and functions docstrings and descriptions
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I moved all functions from the script file (except the argparser and main) to scilpy modules
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
Quick description
Second attempt at uniformizing the verbose option. I added this line:
logging.getLogger().setLevel(logging.getLevelName(args.verbose))
to all scripts, and modified the way the verbose argument is used (in scilpy.io.utils). I also cleaned a bit some modules, so when there was only debug logging, they are now info logging.There might be some scripts like scil_dwi_compute_snr.py that used logging.info to print some results, but with the new default as warning, they won't work properly without -v. I don't know all the script in scilpy so I would need some help to know if I broke anything. :) ...
Type of change
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist