scilus / scilpy

The Sherbrooke Connectivity Imaging Lab (SCIL) Python dMRI processing toolbox
Other
54 stars 59 forks source link

Refactor project_streamlines_to_map #911

Closed EmmaRenauld closed 4 months ago

EmmaRenauld commented 4 months ago

Quick description

Type of change

Check the relevant options.

Provide data, screenshots, command line to test (if relevant)

...

Checklist

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 59.50000% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 69.02%. Comparing base (9412961) to head (39a9f2c). Report is 123 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #911 +/- ## ========================================== + Coverage 68.12% 69.02% +0.90% ========================================== Files 386 389 +3 Lines 20678 20951 +273 Branches 3160 3230 +70 ========================================== + Hits 14087 14462 +375 + Misses 5326 5158 -168 - Partials 1265 1331 +66 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/911/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/911/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `71.58% <70.49%> (+0.90%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/911/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `64.67% <42.30%> (+0.90%)` | :arrow_up: |
pep8speaks commented 4 months ago

Hello @EmmaRenauld, Thank you for updating !

Line 228:80: E501 line too long (80 > 79 characters)