karanphil commented 4 months ago

Quick description

Quick PR to add support and test for multi-shell FRF in scil_frf_mean.py. Should be easy to review.

...

Type of change

Check the relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

[ ] My code follows the style guidelines of this project (run autopep8)
[ ] I added relevant citations to scripts, modules and functions docstrings and descriptions
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I moved all functions from the script file (except the argparser and main) to scilpy modules
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

pep8speaks commented 4 months ago

Hello @karanphil, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-03-01 13:04:03 UTC

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 69.38%. Comparing base (4c2848c) to head (1dad90c). Report is 48 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #930 +/- ## ========================================== + Coverage 69.17% 69.38% +0.21% ========================================== Files 389 389 Lines 20963 21000 +37 Branches 3233 3232 -1 ========================================== + Hits 14501 14571 +70 + Misses 5132 5114 -18 + Partials 1330 1315 -15 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/930/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/930/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `71.81% <66.66%> (+0.21%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/930/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `65.25% <ø> (+0.20%)` | :arrow_up: |

scilus / scilpy