scilus / scilpy

The Sherbrooke Connectivity Imaging Lab (SCIL) Python dMRI processing toolbox
Other
54 stars 59 forks source link

Split load_and_verify_mti function #933

Closed karanphil closed 4 months ago

karanphil commented 4 months ago

Quick description

New little PR! First, I changed the name of the function io.mti.verifications_and_loading_mti to io.mti.load_and_verify_mti. Then, I simply added two new local functions _parse_acquisition_parameters and _prepare_B1_map, making the big function less big.

...

Type of change

Check the relevant options.

Provide data, screenshots, command line to test (if relevant)

...

Checklist

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 72.22222% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 69.50%. Comparing base (4491228) to head (b981950). Report is 15 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #933 +/- ## ========================================== + Coverage 69.46% 69.50% +0.04% ========================================== Files 390 392 +2 Lines 20944 20972 +28 Branches 3205 3207 +2 ========================================== + Hits 14548 14576 +28 Misses 5093 5093 Partials 1303 1303 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/933/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/933/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `71.93% <100.00%> (+0.01%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/933/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `65.51% <70.58%> (+0.09%)` | :arrow_up: |