scilus / scilpy

The Sherbrooke Connectivity Imaging Lab (SCIL) Python dMRI processing toolbox
Other
60 stars 60 forks source link

[ENH] Add possibility to use a label mask with two values to cut streamlines #945

Closed arnaudbore closed 5 months ago

arnaudbore commented 6 months ago

Quick description

New way of cutting streamlines. Use a label image and select your IDs to cut streamlines ...

Type of change

Check the relevant options.

Provide data, screenshots, command line to test (if relevant)

...

Checklist

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 44.68085% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 67.99%. Comparing base (173f70b) to head (9c0c7b3). Report is 42 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #945 +/- ## ========================================== + Coverage 66.98% 67.99% +1.00% ========================================== Files 396 397 +1 Lines 21396 21396 Branches 3251 3239 -12 ========================================== + Hits 14333 14549 +216 + Misses 5749 5532 -217 - Partials 1314 1315 +1 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/945/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/945/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `68.98% <45.23%> (+0.92%)` | :arrow_up: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/945/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `66.48% <40.00%> (+1.16%)` | :arrow_up: |
pep8speaks commented 6 months ago

Hello @arnaudbore, Thank you for updating !

Line 164:80: E501 line too long (84 > 79 characters)

Comment last updated at 2024-04-10 18:58:04 UTC
frheault commented 5 months ago

It works well!

Could you add the parameters to use in the error message (--label_ids) parser.error('More than two values in the label file.')