EmmaRenauld commented 3 months ago

Quick description

Renaming scil_compute_pca and scil_convert_tensors. ...

Type of change

Check the relevant options.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

[ ] My code follows the style guidelines of this project (run autopep8)
[ ] I added relevant citations to scripts, modules and functions docstrings and descriptions
[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I moved all functions from the script file (except the argparser and main) to scilpy modules
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

pep8speaks commented 3 months ago

Hello @EmmaRenauld, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-03-18 14:23:02 UTC

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 66.43%. Comparing base (1d8d122) to head (c85b116).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #946 +/- ## ========================================== - Coverage 66.95% 66.43% -0.53% ========================================== Files 392 395 +3 Lines 21037 21049 +12 Branches 3197 3197 ========================================== - Hits 14086 13983 -103 - Misses 5656 5776 +120 + Partials 1295 1290 -5 ``` | [Components](https://app.codecov.io/gh/scilus/scilpy/pull/946/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | Coverage Δ | | |---|---|---| | [Scripts](https://app.codecov.io/gh/scilus/scilpy/pull/946/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `67.72% <0.00%> (-0.35%)` | :arrow_down: | | [Library](https://app.codecov.io/gh/scilus/scilpy/pull/946/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=scilus) | `64.33% <ø> (-0.83%)` | :arrow_down: |

EmmaRenauld commented 3 months ago

I just discovered that here: https://app.codecov.io/gh/scilus/scilpy/tree/master/scripts%2Flegacy

Some legacy files are used! Fixes.

scilus / scilpy